[BUGFIX beta] [PERF] Cache FactoryManagers #15009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 1 FactoryManager per container/normalizeFullName * cache madeToString per factoryManager
krisselden
reviewed
Mar 14, 2017
| let factory = this.registry.resolve(normalizedName); | ||
|
|
||
| if (factory === undefined) { return; } | ||
| if (factory === undefined) { |
There was a problem hiding this comment.
should misses not cache?
There was a problem hiding this comment.
i thought so, but there where test failures and I'm tired :P Maybe i can convince @chadhietala to investigate?
There was a problem hiding this comment.
resolve does also cache so its not the end of the world either..
chadhietala
approved these changes
Mar 14, 2017
|
Added tests to make sure the |
rwjblue
reviewed
Mar 14, 2017
packages/container/lib/container.js
Outdated
| @@ -38,6 +38,7 @@ export default function Container(registry, options) { | |||
| this.owner = options && options.owner ? options.owner : null; | |||
| this.cache = dictionary(options && options.cache ? options.cache : null); | |||
| this.factoryCache = dictionary(options && options.factoryCache ? options.factoryCache : null); | |||
| this.factoryManagerCache = dictionary(options && options.factoryCache ? options.factoryCache : null); | |||
There was a problem hiding this comment.
This should not share the same cache as this.factoryCache. I suspect this should be:
this.factoryManagerCache = dictionary(options && options.factoryManagerCache ? options.factoryManagerCache : null);
|
Thanks @chadhietala |
|
benchmarks (4.7x improvement): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fixes #15007]