Refactor {{mount}} syntax #14967
Merged
Refactor {{mount}} syntax #14967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
reviewed
Mar 2, 2017
| this.nameRef = nameRef; | ||
| this.env = env; | ||
| this.symbolTable = symbolTable; | ||
| this.args = args; |
chancancode
reviewed
Mar 2, 2017
| } | ||
|
|
||
| this._lastName = nameOrDef; | ||
| this._lastDef = new MountDefinition(nameOrDef, env); |
There was a problem hiding this comment.
Remove env from MountDefinition
chancancode
approved these changes
Mar 2, 2017
|
Thanks for the review, I believe I have resolved all of the issues that were raised. |
|
Awesome! 👏 |
|
Next up: allowing bound engine names? |
|
Thanks! Yep, bound engine names next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes ember-engines/ember-engines#338
This PR adds no new functionality and is purely a refactor of the
{{mount}}syntax in order to lay the ground work required for:cc/ @rwjblue