[BUGFIX beta] Fixes binding in input type=checkbox #14947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaljach
approved these changes
Mar 10, 2017
|
It appears this test passes without the above provided fix. PR: #15162 with just the test (Tested both beta and canary) will gladly reopen if there is an additional test case that this missed, but the PR fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug described in #14933.
Demo that shows bug is here
When input has bound
checkproperty it should be possible to check/uncheck checkbox by controlling this property, but right now it is not possible when checkbox is clicked, because this property is overwrote by jQuery value.