Remove unneeded check as data-ember-action no longer contains a value
#14871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinJoyce
changed the title
data-ember-action no longer has a valuedata-ember-action no longer contains a value
GavinJoyce
changed the title
data-ember-action no longer contains a valuedata-ember-action no longer contains a value
GavinJoyce
changed the title
data-ember-action no longer contains a valuedata-ember-action no longer contains a value
GavinJoyce
force-pushed
the
gj/simplify-event-handler
branch
from
cb93920 to
4f9dcfb
Compare
GavinJoyce
force-pushed
the
gj/simplify-event-handler
branch
from
4f9dcfb to
7e177ec
Compare
GavinJoyce
changed the title
data-ember-action no longer contains a valuedata-ember-action no longer contains a value
|
this is 🍏 and ready for review |
1 task
| } | ||
| let attributes = evt.currentTarget.attributes; | ||
| let attributeCount = attributes.length; | ||
| let actions = []; |
There was a problem hiding this comment.
allocating this array even if we don't need too is a-bit strange. (not a big deal though)
There was a problem hiding this comment.
ya, i guess this really doesn't matter here :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Glimmer 2 action helper doesn't set a value for
data-ember-action, so we no longer need to compare it to"".