Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate renderToElement #14482

Merged
merged 1 commit into from
Nov 13, 2016
Merged

Deprecate renderToElement #14482

merged 1 commit into from
Nov 13, 2016

Conversation

josemarluedke
Copy link
Sponsor Contributor

This implements #14158.

Deprecation guide: emberjs/website#2702.

@josemarluedke josemarluedke mentioned this pull request Oct 16, 2016
Merged
josemarluedke
josemarluedke commented Oct 16, 2016
View reviewed changes
packages/ember-views/lib/mixins/view_support.js
false,
{
id: 'ember-views.render-to-element',
until: '3.0.0',
Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if 3.0.0 is the intended version to drop this, can someone confirm?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this would be until: '2.12.0'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update this then.

Copy link
Sponsor Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@Gaurav0
Copy link
Contributor

Gaurav0 commented Oct 18, 2016

appendTo is private. Please do not merge this unless there is another public way to render a component programmatically.

@rwjblue
Copy link
Member

rwjblue commented Oct 18, 2016 •
edited
Loading

appendTo is private. Please do not merge this unless there is another public way to render a component programmatically

@Gaurav0 - That really isn't a compelling motivation. Both renderToElement and appendTo are private, this is just deprecating one private mechanism in favor of another.

I totally agree that we should have a public API for this though, maybe you can try your hand at writing the RFC if this is something you need?

@rwjblue rwjblue mentioned this pull request Oct 18, 2016
Closed
@rwjblue rwjblue merged commit 02d36cb into emberjs:master Nov 13, 2016
@rwjblue
Copy link
Member

rwjblue commented Nov 13, 2016

Thank you @josemarluedke!

@josemarluedke josemarluedke deleted the depecate-render-to-element branch November 13, 2016 04:56
@rwjblue rwjblue mentioned this pull request Nov 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

@chancancode chancancode chancancode left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josemarluedke @Gaurav0 @rwjblue @chancancode