[BUGFIX release] Avoid assertion when bound id provided to tagless component
#14382
Conversation
|
Eeck, good catch. Yes, can you PR this test against master too? |
|
|
||
| this.render(`{{#foo-bar id=fooBarId}}{{/foo-bar}}`, { fooBarId: 'baz' }); | ||
|
|
||
| this.assertText('baz'); |
There was a problem hiding this comment.
Can you test updating the id and resetting it back to the original value? (The point of this test is to make sure we don't throw when you update the id value on a tag less component). 😄
There was a problem hiding this comment.
Yes. Should the other tests in this file be doing the same thing?
|
Just ran into this ... quite desperate to get this into 2.8.x. By being in "release" does that mean it'll make the next release in a few days? Is there any workaround until then? For me at least, this is a big deal because I am developing an addon and the default config for addons is broken in Inspector for 2.9.0 so I can't develop there either issue. I'm using |
|
@ksnyde - Yes, this PR targeted the release branch (and you can use this channels build today if you'd like), and it will be included in 2.8.2 when we release it (likely Monday). |
Fixes #14369
I'm not totally sure about the protocol for submitting this change. The code fix is for code that is totally gone in 2.9+ but the test might still be useful to have around in later versions.
@chancancode is this what you were thinking?