Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow paths beginning with @ in templates #13913

Merged
merged 1 commit into from
Jul 27, 2016

Conversation

courajs
Copy link
Contributor

@courajs courajs commented Jul 27, 2016

No description provided.

@courajs
Copy link
Contributor Author

courajs commented Jul 27, 2016

ping @chancancode

@rwjblue
Copy link
Member

rwjblue commented Jul 27, 2016

This looks good to me, thank you @courajs!

@chadhietala chadhietala merged commit 798ba8a into emberjs:master Jul 27, 2016
@chadhietala
Copy link
Contributor

Thanks @courajs!

compile('{{input type=(if @foo "bar" "baz")}}', {
moduleName: 'baz/foo-bar'
});
}, `'@foo' is not a valid path. ('baz/foo-bar' @ L1:C17) `);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@courajs can you add another test for <foo-bar @foo="bar" />?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can open another PR tmw. Any others I should include?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are the main ones I can think of, thanks!

@courajs courajs deleted the assert-reserved-named-arguments branch March 27, 2017 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants