[Glimmer 2] Unskip tests related to inline styles and unsafe hrefs #13811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| ['@test specifying `<div style={{{userValue}}}></div>` works properly without a warning'](assert) { | ||
| ['@htmlbars specifying `<div style={{{userValue}}}></div>` works properly without a warning'](assert) { |
There was a problem hiding this comment.
@krisselden Not sure how to handle this case because we have a TrustingAppendOpcode here which blindly appends and the context is lost in the compile.
|
@rwjblue Does this test indicator mean that typescript needs to be a |
|
I don't think so, we are using 2.0.0-dev, but that isn't one of the options allowed. |
chadhietala
force-pushed
the
much-secure
branch
3 times, most recently
from
60c441b
to
f64eba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13644