[CLEANUP] reducing private API surface of views. #13773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @private | ||
| */ | ||
| nearestWithProperty(property) { | ||
| let view = get(this, 'parentView'); | ||
| let view = this.parentView; | ||
|
|
||
| while (view) { | ||
| if (property in view) { return view; } | ||
| view = get(view, 'parentView'); |
There was a problem hiding this comment.
This should be deleted (it is causing a JSHInt error).
* remove unused internal `_willDestroyElement` hook * cleanup `childViews` documentation not to refer to legacy methods * remove undocumented `forEachChildView` used only by visibility support and refactor visibility support not to use it. * remove `remove` and `removeFromParent` methods, refactor legacy style tests to avoid these. Removing a view should be done via the template layer. Still leaves destroyElement which is equivalent and used in more legacy style tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_willDestroyElementhookchildViewsdocumentation not to refer to legacy methodsforEachChildViewused only by visibility supportand refactor visibility support not to use it.
removeandremoveFromParentmethods, refactor legacy styletests to avoid these. Removing a view should be done via the template
layer. Still leaves destroyElement which is equivalent and used in more
legacy style tests.