[Glimmer 2] Remove tests related to legacy ember-test-helpers #13671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are specifically testing patterns that used to be used in ember-test-helpers. Since these tests have been introduced ember-test-helpers has moved to the container pattern with `lookupFactory`. In general we need to start migrating tests away from things that did not come out of the container with injections on them. This is because we need to remove this hardcoded `InteractiveRenderer` [here](https://github.com/emberjs/ember.js/blob/master/packages/ember-views/lib/views/core_view.js#L46-L52)
chadhietala
force-pushed
the
nuke-link-to-tests-related-to-qunit
branch
from
b0b1de7
to
1e2aed4
Compare
|
@rwjblue Can you confirm this is ok? |
|
I'd like to keep the tests, but we need to build the registry properly. The issue here is that these tests do not use |
|
Yea I walked through the code to figure out why it was failing. Do you know of other tests that go through |
|
I think moving them to ember package may be a better bet. |
|
Rebased in #13713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are specifically testing patterns that used to be used in
ember-test-helpers. Since these tests have been introduced
ember-test-helpers has moved to the container pattern with
lookupFactory. In general we need to start migrating tests away fromthings that did not come out of the container with injections on them.
This is because we need to remove this hardcoded
InteractiveRendererhere
Part of #13644