Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring cleaning #13658

Merged
merged 1 commit into from
Jun 15, 2016
Merged

spring cleaning #13658

merged 1 commit into from
Jun 15, 2016

Conversation

stefanpenner
Copy link
Member

@stefanpenner stefanpenner commented Jun 13, 2016

I can gladly split this up by file, or by module or by folder or leave it as is. Open to recommendations.

  • use let/const when appropriate (and according to style guide) no more var
  • concise functions when appropriate
  • use => were appropriate

@stefanpenner stefanpenner force-pushed the cleanup branch 10 times, most recently from 9a65285 to 47837d6 Compare June 13, 2016 03:07
@Turbo87
Copy link
Member

Turbo87 commented Jun 13, 2016

I see a lot of conflicts with #13549 ahead of me... 😄

@stefanpenner stefanpenner force-pushed the cleanup branch 8 times, most recently from cfd7094 to 95369f0 Compare June 15, 2016 18:03
@stefanpenner
Copy link
Member Author

I see a lot of conflicts with #13549 ahead of me... 😄

I can rebase that for you once this lands

@stefanpenner stefanpenner changed the title cleanup spring cleaning Jun 15, 2016
@Turbo87
Copy link
Member

Turbo87 commented Jun 15, 2016

don't worry, I can take it 😉

@Turbo87
Copy link
Member

Turbo87 commented Jun 15, 2016

I'd appreciate an r+ on emberjs/emberjs-build#163 though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants