[BUGFIX release] Remove Ember.merge deprecation. #13344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deprecation was too noisy, and not enough libraries updated prior to release (to avoid deprecation). At this point the deprecation is just a nuisance to our users.
|
LGTM |
|
Just to clarify, the plan is still to eventually deprecate and remove |
|
@workmanw i believe the plan is to re-evaluate at a later date. |
|
Confirm. We do not currently have plans to reintroduce, but I would be somewhat surprised if both methods make it into 3.0.0. But obviously that is quite a ways away, and we don't really know what that will look like. |
|
@stefanpenner @rwjblue Thanks for the clarifications! |
workmanw
pushed a commit
to workmanw/ember-website
that referenced
this pull request
Apr 17, 2016
…ember.js#13344 it is being undeprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deprecation was too noisy, and not enough libraries updated prior to release (to avoid deprecation). At this point the deprecation is just a nuisance to our users.