[DOC release] updated docs regarding ember debug methods

[webark]

This brings them all in line with #13180

Was brought up during conversation in ember-cli/rfcs#50 (comment)

[justinaray]

Is make the assertion a copy/paste mistake from the assert jsdoc?

[mixonic]

Seems like it should say deprecation. Is that really the app-space behavior for deprecate in prod?

[justinaray]

I think this was to eventually match the behavior to be implemented by ember-cli/rfcs#50. Although it's not clear from the discussion thus far if the impl will remove the calls or noop the impl.

We recently came across this when we removed all custom deprecation handlers and the default Ember console.log implementation started to flood our prod consoles. The docs definitely mislead us in this case.

I took from my slack conversation that this RFC was to land quickly. Which might be the motivation not to updated the docs to match current behavior only to change them back after impl?

[mixonic]

We should definitely not add documentation that is incorrect, but would be if/when some other work lands. Right?

[webark]

Ya, I was simply copying and pasting from what was decided in #13180 and seems like some better wording should be done. The motivation for this PR was two things. First, based off of the current documentation, I thought that Ember.info would behave the same in production, cause it never said elsewise in the documentation. Second, it does seem based off of the wording that it will actually remove the calls, not just turn them into a empty function.

[webark]

I'll update the wording for them though so that it's a little better then a ✂️ 🍯 (didn't have a brush or glue. figure honey could be used as glue in a pinch)

[webark]

was just basing which methods where 'no-op'ed from this. https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/debug.js I left out the debug seal cause there was no documentation on that as is.

[mixonic]

Seems totally great to move forward with! We should just be sure the docs are accurate 😄

[webark]

@mixonic @justinaray Updated to hopefully be more strait forward and less wordy. Once ember-cli/rfcs#50 is complete, the documentation could be updated to reflect the eventual implementation.

[mixonic]

Can we note both behaviors?

• In a production build, this method is defined as an empty function (NOP). Uses of this method in Ember itself are stripped from the ember.prod.js build.

[mixonic]

I've noted two spots where we should mention the calls being stripped from production, but you should look to the actual list for confirmation:

• https://github.com/emberjs/ember.js/blob/master/ember-cli-build.js#L38

Thanks! 👏

[webark]

@mixonic updated! And no worries! 😄

[mixonic]

Thanks @webark!