[BUGFIX release] Ensure {{render}} sets up target properly.
#13185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the _ENABLE_LEGACY_CONTROLLER_SUPPORT flag is disabled, the
`controller` local is `undefined`. This causes the controller created by
`{{render}}` to have an undefined `target` (so it swallows any actions
triggered).
This properly sets the `target` to `router:main` if there is no
`parentController` present.
rwjblue
force-pushed
the
ensure-render-can-have-actions
branch
from
590ba25 to
6f01942
Compare
|
Thank you! |
|
Included in v2.4.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the _ENABLE_LEGACY_CONTROLLER_SUPPORT flag is disabled, the
controllerlocal isundefined. This causes the controller created by{{render}}to have an undefinedtarget(so it swallows any actions triggered).This properly sets the
targettorouter:mainif there is noparentControllerpresent.Fixes #13182.