[BUGFIX release] Add mut to attributes in contextual components #13177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I restarted the sauce labs tests, but can you also update the prefix to |
As explained in issue emberjs#13061, given a component `change-button` with template: ```hbs <button {{action (action (mut val) 10)}}>Change to 10</button> ``` If it is invoked as in the following template: ```hbs {{change-button val=value}} <span class="value"> {{value}} </span> ``` Clicking on the button will cause `.value` to contain `10`. On the other hand, invoking it via a closure component: ```hbs {{component (component "change-button" val=value)}} <span class="value"> {{value}} </span> ``` Clicking on the button will not change the text in `.value`. This PR adds a transform that adds `mut` to params and hash values.
Serabe
changed the title
|
Done! |
|
OK, this looks good to me. I'm going to land into canary and beta for some testing, but will backport into the LTS before shipping (assuming all is good). |
|
Thank you @Serabe! |
|
Thanks. If you see any report that might be related to this, just mention
me, please.
|
|
Included in v2.4.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in issue #13061, given a component
change-buttonwith template:If it is invoked as in the following template:
Clicking on the button will cause
.valueto contain10.On the other hand, invoking it via a closure component:
Clicking on the button will not change the text in
.value.This PR adds a transform that adds
mutto params and hash values.