[Glimmer2] [CLEANUP canary] Remove deprecated legacy-each support including {{collection}} #13161
Conversation
| @@ -1,21 +1,9 @@ | |||
| {{~#each view._arrangedContent -legacy-keyword=view.keyword as |item|~}} | |||
There was a problem hiding this comment.
I think this whole file should 🔥
Yes
No |
HeroicEric
force-pushed
the
remove-collection
branch
2 times, most recently
from
a597a00 to
7ab839f
Compare
HeroicEric
changed the title
collection test
|
@rwjblue I still need to update the two references to Should squash when done? |
| registerPlugin('ast', AssertNoViewAndControllerPaths); | ||
| registerPlugin('ast', AssertNoViewHelper); | ||
| } | ||
| registerPlugin('ast', AssertNoViewAndControllerPaths); |
There was a problem hiding this comment.
These should only be registered if the legacy view flag is off. We definitely should have a follow up PR to remove the flag and all usages of it, but it should be a separate change from this one IMO.
|
I left one more tweak, but this is looking good. Once you have those docs updated, go ahead and squash and we can land this... |
HeroicEric
force-pushed
the
remove-collection
branch
from
7ab839f to
483ff75
Compare
For emberjs#13127 - Remove {{each itemView=}} - Remove {{each itemViewClass=}} - Remove {{each itemController=}} - Remove {{each tagName=}} - Remove legacy-each-* - Remove TransformEachIntoCollection - Remove `CollectionView` This was done in order to clean up deprecated features to make the transition to Glimmer 2 easier, since these features won't need to be supported by Glimmer 2.
HeroicEric
force-pushed
the
remove-collection
branch
from
483ff75 to
2b2fa57
Compare
HeroicEric
changed the title
HeroicEric
changed the title
|
I think this is all set 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 |
| @@ -114,13 +114,16 @@ NativeArray = NativeArray.without.apply(NativeArray, ignore); | |||
|
|
|||
| Example | |||
|
|
|||
| TODO: Update example to not use CollectionView | |||
There was a problem hiding this comment.
Need to kill this TODO comment, looks like the docs below already took care of it...
|
Sorry, just one more nit to pick... |
|
Thanks for this @HeroicEric! |
I spent some time trying to figure out how to remove the
collectionhelper/keyword/view for #13127. As far as I can tell, a bunch of other things depend on it and also need to be removed in order to do so.{{each itemView=}}{{each itemViewClass=}}{{each itemController=}}{{each tagName=}}{{each emptyView=}}{{each emptyViewClass=}}{{collection}}Much of my thoughts here are based on my understanding of what's going on in https://github.com/emberjs/ember.js/blob/master/packages/ember-template-compiler/lib/plugins/transform-each-into-collection.js#L43-L57
There is still cleanup to do here but I tried to organize the commits so that they could possibly be brought in separately. That worked fine until I got to actually removing the
Questions
Guidance welcomed 😄