[CLEANUP canary] Remove Ember.Select #13144
Conversation
HeroicEric
changed the title
HeroicEric
force-pushed
the
remove-view-select
branch
from
a5fc537 to
d2b9410
Compare
|
@HeroicEric next round is on me ❤️ |
|
Can we make this Canary? I don't see much of a reason for dropping legacy helpers in 2.5-beta. It is already a beta release, we missed the boat, no need to rush this. |
As requested in emberjs#13127: This removes `Ember.Select`. Views were removed from the 2.0 API unless using the ember-legacy-views addon, which is intended to end support after Ember v2.4. This includes `Ember.select`. http://emberjs.com/deprecations/v1.x/#toc_ember-view
|
Agreed. Canary seems good. |
|
good night sweet prince |
HeroicEric
force-pushed
the
remove-view-select
branch
from
d2b9410 to
4b5b972
Compare
HeroicEric
changed the title
|
Updated the commit message for canary |
|
Thanks @HeroicEric 🔥 🔥 🔥 🔥 🔥 🔥 🔥 |
|
I'm merging this after some discussion by a subset of core. We continue to make progress on landing the glimmer refactor into Ember master (see epic burndown). It is not expected that this work makes into into canary in time for Ember 2.6, however good progress is being made. In several recent blog posts and issues core has raised that Ember 2.4 will likely be the final release supporting the legacy view and controller APIs. It looks like that may actually be 2.5, but as 2.4 is an LTS support will live on in 2.4 for far longer than 2.5 regardless. So that landing the glimmer refactor work is not a complete rush, we're opening the current canary (2.6) to removals of APIs incompatible with the glimmer refactor. Additionally this will be an opportunity to cull a good amount of code from Ember that has only existed to support the legacy addons via intimate feature flags. These are already deprecated in 2.4 per the LTS guidelines. Please see the deprecation guide for further details about migrating away from Ember's select solution, or try out the fantastic ember-power-select. |
[CLEANUP canary] Remove Ember.Select
|
@mixonic I would probably be more circumspect about exact versions 😉 The high order bit is we want to ship Glimmer 2 as soon as we can, but no sooner. In the meantime, we'll have the six-week release cycle to keep us warm at night. (I should add that what you said sounds plausible, but by no means guaranteed. Promising exact dates, even hedged, is a good way to feel pressured into shipping too early.) |
`Ember.Select` was deprecated and then removed as of emberjs/ember.js#13144. This removes ember-engine's reference to `Ember.Select` to bring engines up to compatibility with Ember 2.4+.
`Ember.Select` was deprecated and then removed as of emberjs/ember.js#13144. This removes ember-engine's reference to `Ember.Select`.
As requested in #13127:
This removes
Ember.Select.Views were removed from the 2.0 API unless using the ember-legacy-views addon, which is intended to end support after Ember v2.4. This includes
Ember.select.http://emberjs.com/deprecations/v1.x/#toc_ember-view