Implement Ember semantics for Glimmer {{#each}} #13048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As usual, we only ported enough tests to test the system is working, and
we need to finish porting the rest of the tests (we actually haven’t
looked into the existing each tests yet – we just borrowed the {{#with}}
tests as a starting point). However, since we are now sharing the same
basic test cases from the conditionals test, we already covered a lot of
ground from-the-get-go.
These are fixed in glimmerjs/glimmer-vm@2910a5b
Also cleaned up the {{#with}} tests a bit, e.g. remove duplicated tests,
following the mutation -> replacement cycle, etc
| this.runTask(() => set(this.context, 'otherThing', 'biz')); | ||
|
|
||
| this.assertText('No Thing biz'); | ||
|
|
There was a problem hiding this comment.
Missing test for updating the outer var
|
@chadhietala I think I fixed some issues with the |
chancancode
added a commit
that referenced
this pull request
Mar 4, 2016
Implement Ember semantics for Glimmer {{#each}}
26 tasks
52 tasks
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual, we only ported enough tests to test the system is working, and we need to finish porting the rest of the tests (we actually haven’t looked into the existing each tests yet – we just borrowed the
{{#with}}tests as a starting point). However, since we are now sharing the same basic test cases from the conditionals test, we already covered a lot of ground from-the-get-go.