WIP Restore meta-descs #12802
Closed
WIP Restore meta-descs #12802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stefanpenner
commented
Jan 11, 2016
stefanpenner
commented
- make it work
- fix remaining failing tests
- cleanup code
- write deprecation/fallback code for users who accidentally used the unintentional API this provided (we can choose to not deprecate if we don't want)
- fix some performance things i noticed
- ensure performance is comparable (or better)
|
☔ The latest upstream changes (presumably #12491) made this pull request unmergeable. Please resolve the merge conflicts. |
stefanpenner
force-pushed
the
restore-meta-descs
branch
from
4fba54c to
2e7991e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.