[BUGFIX beta] Expose ownerInjection method on ContainerProxy. #12629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -519,6 +519,16 @@ QUnit.test('Lazy injection validations are cached', function() { | |||
| container.lookup('apple:main'); | |||
| }); | |||
|
|
|||
| QUnit.test('A registered factory is returned from lookupFactory', function() { | |||
There was a problem hiding this comment.
This test title should reference ownerInjection. Perhaps "An object with its owner pre-set should be returned from ownerInjection".
|
LGTM other than that test title 👍 |
The `ember-container-inject-owner` feature provides a public API for
accessing various container/registry functions. Unfortunately, creating
an instance that has access to the same owner is a somewhat annoying
API compared to what we would do today.
In Ember 2.2 you would often do this (though it still uses private API):
```js
User.create({
container: this.container,
username: 'John'
});
```
But in 2.3.0-beta.1 to do roughly the same thing, you would have to do:
```js
var options = { username: 'John' };
setOwner(options, getOwner(this));
User.create(options);
```
This is definitely less ergonomic for a perfectly supported case. With
the changes added here, you would use the following:
```js
User.create(
getOwner(this).ownerInjection(),
{ username: 'John' }
);
```
rwjblue
force-pushed
the
add-owner-injection
branch
from
108bf1f
to
6d063b8
Compare
rwjblue
added a commit
that referenced
this pull request
Nov 20, 2015
[BUGFIX beta] Expose ownerInjection method on ContainerProxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ember-container-inject-ownerfeature provides a public API for accessing various container/registry functions. Unfortunately, creating an instance that has access to the same owner is a somewhat annoying API compared to what we would do today.In Ember 2.2 you would often do this (though it still uses private API):
But in 2.3.0-beta.1 to do roughly the same thing, you would have to do:
This is definitely less ergonomic for a perfectly supported case. With the changes added here, you would use the following:
/cc @dgeb (as we previously discussed)