Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RSVP dependency #12532

Merged
merged 1 commit into from
Oct 30, 2015
Merged

Bump RSVP dependency #12532

merged 1 commit into from
Oct 30, 2015

Conversation

dschmidt
Copy link
Contributor

Hey,

would be nice to have latest rsvp which adds the label as second argument to the on('error', ...) hook.

tildeio/rsvp.js#404

BR,
Domme

@rwjblue
Copy link
Member

rwjblue commented Oct 29, 2015

Seems good to me.

@stefanpenner - Any objections?

@rwjblue
Copy link
Member

rwjblue commented Oct 29, 2015

(Build is broken on master due to a downstream dep change, not necessarily this PR)

@stefanpenner
Copy link
Member

@stefanpenner - Any objections?

nope LGTM

@dschmidt
Copy link
Contributor Author

Rebased but sauce build still fails, everything else is green

@stefanpenner
Copy link
Member

potentially just a random saucelabs error, kicking it.

@dschmidt
Copy link
Contributor Author

Looks like, before Edge was failing, now it's IE9 and IE10.. can you kick it again?

@stefanpenner
Copy link
Member

@dschmidt kicking

Someone should likely add some basic retry (up to two times or something) to the sauce lab tests..

@dschmidt
Copy link
Contributor Author

Everything passed! 👍

stefanpenner added a commit that referenced this pull request Oct 30, 2015
@stefanpenner stefanpenner merged commit 844e43d into emberjs:master Oct 30, 2015
@stefanpenner
Copy link
Member

thank you kindly sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants