Backport PR 11983 to beta #12036
Merged
Backport PR 11983 to beta #12036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breakup set method into a top level branching method that has 4 paths, readonly check/throw, clobber set, volatile set or normal set. `volatile()` does not simply mean don’t cache, it means this value is inherently not observable and/or you need to manually notify/cache the value. ArrayProxy is a good example, length is observable but has to be manually notified for NativeArray mixin, so ArrayProxy just delegates to the underlying array but doesn’t setup DKs or any notification since it is notified already by the mutation methods. It is not an escape value for you not getting the correct DKs or it seems to solve some bug I can’t figure out. It is not the equivalent of the old sprout core behavior and hasn’t been for a while. If you have a dependency that does not fit into a DK, you can notifyPropertyChange() manually. If you don’t understand the above you should not be using `volatile` it has an extremely narrow use case. Conflicts: packages/ember-metal/lib/chains.js packages/ember-metal/lib/computed.js Cherry-picked from 4678ce9
|
Thank you! |
|
Also, "set" does not return the value of the object itself anymore. Instead it returns the value being set. Thus chaining is no longer possible. Was that done intentionally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per request by @rwjblue.