Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Fix DeprecatedView (and friends) reopen function to delegate to original #11866

Merged
merged 1 commit into from Jul 24, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jul 23, 2015

Fixes #11849

@rwjblue
Copy link
Member

rwjblue commented Jul 23, 2015

Thanks for tackling this, I am unsure if we need to also add a deprecation upon reopen.

Con: - That there really is no way of doing what #11849 wants to do (adding attributeBindings for all data-* properties) while avoiding a deprecation.

Pro - I do not think we really want folks to do this without the addon at all (because in 2.0.0 they are not going to be exported without the addon).

@rwjblue
Copy link
Member

rwjblue commented Jul 23, 2015

@martndemus - Would you mind adding a deprecation for these using the legacy views env flag to disable (and until set to 2.4.0)?

@ghost
Copy link
Author

ghost commented Jul 23, 2015

@rwjblue like so?

mixonic added a commit that referenced this pull request Jul 24, 2015
[BUGFIX release] Fix DeprecatedView (and friends) reopen function to delegate to original
@mixonic mixonic merged commit e927f3b into emberjs:master Jul 24, 2015
@mixonic
Copy link
Sponsor Member

mixonic commented Jul 24, 2015

Thanks sir :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants