Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Deprecate Ember.ContainerView #11826

Merged
merged 1 commit into from Jul 20, 2015
Merged

[BUGFIX release] Deprecate Ember.ContainerView #11826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/ember-views/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {
import Renderer from 'ember-metal-views/renderer';
import { DeprecatedCoreView } from 'ember-views/views/core_view';
import { DeprecatedView } from 'ember-views/views/view';
import ContainerView from 'ember-views/views/container_view';
import { DeprecatedContainerView } from 'ember-views/views/container_view';
import CollectionView from 'ember-views/views/collection_view';
import Component from 'ember-views/views/component';

Expand Down Expand Up @@ -85,7 +85,7 @@ Ember.SelectOptgroup = SelectOptgroup;

Ember.TextSupport = TextSupport;
Ember.ComponentLookup = ComponentLookup;
Ember.ContainerView = ContainerView;
Ember.ContainerView = DeprecatedContainerView;
Ember.CollectionView = CollectionView;
Ember.Component = Component;
Ember.EventDispatcher = EventDispatcher;
Expand Down
8 changes: 8 additions & 0 deletions packages/ember-views/lib/views/container_view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ containerViewTemplate.meta.revision = 'Ember@VERSION_STRING_PLACEHOLDER';
@class ContainerView
@namespace Ember
@extends Ember.View
@deprecated See http://emberjs.com/deprecations/v1.x/#toc_ember-containerview
@private
*/
var ContainerView = View.extend(MutableArray, {
Expand Down Expand Up @@ -302,4 +303,11 @@ var ContainerView = View.extend(MutableArray, {
})
});

export var DeprecatedContainerView = ContainerView.extend({
init() {
Ember.deprecate('Ember.ContainerView is deprecated.', !!Ember.ENV._ENABLE_LEGACY_VIEW_SUPPORT , { url: 'http://emberjs.com/deprecations/v1.x/#toc_ember-containerview' });
this._super.apply(this, arguments);
}
});

export default ContainerView;