Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[CLEANUP beta] Remove support for reversed args in Ember.Obse… #11824

Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jul 20, 2015

Reverts #11782. The release version of the ember-inspector used the deprecated format. It doesn't cost us much to keep the old version around with the deprecation.

Fixes #11803.

rwjblue added a commit that referenced this pull request Jul 20, 2015
…arguments_order_in_observer

Revert "[CLEANUP beta] Remove support for reversed args in Ember.Obse…
@rwjblue rwjblue merged commit 96e2de0 into master Jul 20, 2015
@rwjblue rwjblue deleted the revert-11782-remove_alternate_arguments_order_in_observer branch July 20, 2015 14:45
@cibernox
Copy link
Contributor

Ooops

@stefanpenner
Copy link
Member

cc @teddyzeenny

@rwjblue
Copy link
Member Author

rwjblue commented Jul 20, 2015

@cibernox - No worries!

@cibernox
Copy link
Contributor

That makes me think. Will be at some point a ember-inspector 2 that removes 1.X compatibility?

@teddyzeenny
Copy link
Contributor

The new inspector version is out - it no longer uses the old observer args.
@cibernox the plan is to have a mode switch between 1.x and 2.x so we would lock the 1.x version and be able to drop 1.x support in the 2.0 version.

@cibernox
Copy link
Contributor

That we can revert the revert for 2.0 stable?

@rwjblue
Copy link
Member Author

rwjblue commented Aug 10, 2015

Nah, it doesn't cost us much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants