[BUGFIX release] add warnings to deprecated Enumerable methods #11774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
emberjs#11700 removes findProperty in Ember 2.0, but there are no deprecation warnings on soon-to-be-removed Enumerable methods.
machty
force-pushed
the
stable-enumerable-deprecations
branch
from
d2a36f9
to
909441d
Compare
machty
added a commit
that referenced
this pull request
Jul 16, 2015
[BUGFIX release] add warnings to deprecated Enumerable methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11700 removes findProperty in Ember 2.0, but there are no deprecation warnings on soon-to-be-removed Enumerable methods in 1.x.
NOTE: the previous alias tests checked for equality of the aliased methods, which is impossible if we're adding deprecations to the aliases, hence I've just commented them out. Doesn't seem like it's worth the time to replace every last one of them with test cases that they're both 1) deprecated and 2) properly aliased given how simple the logic is, but someone let me know if I'm crazy/lazy.