[CLEANUP beta] Remove deprecated Controller#controllerFor

[ghost]

Controller#controllerFor has been deprecated, this commit removes the functionality.

Needs rebase once #11770 is merged.

[stefanpenner]

Although deprecated, we should do our due diligence and explore some points:

1. what needs to be supported by legacy addon
2. what needs to continue to be in core to support basic controllers (since we dont have routable components yet)
3. anything else i'm missing?

[rwjblue]

Ready for rebase.

[ghost]

Rebase'd

[ghost]

@stefanpenner Use Ember.inject.controller() instead. ?

[rwjblue]

This isn't removing the fundamental capability (since inject.controller() works just fine), it is only removing the syntax of using needs instead of inject.controller(). This seems unlike {{view}} and friends where there is no alternative path, so we need an addon.

[stefanpenner]

This seems likely it may want to be part of the legacy controllers addon, what do others think? cc @cibernox

[cibernox]

It could go into the addon, but I don't see a strong necessity since there is an alternative syntax to get the same result. I see this more like a ember-watson task for help in the migration.

[cibernox]

@abuiles you think that it's viable to to create a task that transform needs into Ember.inject.controller() and the replaces occurences of this.controllerFor('whatever') by this.get('whatever')?

[ghost]

@cibernox @abuiles You would also have to transform this.get('controllers.whatever')

[cibernox]

True.
Even if it's not really viable to automate the transformation I don't think that we should keep that feature alive in the addon since the functionality is still here just under a different syntax.

[stefanpenner]

I see this more like a ember-watson task for help in the migration.

true – although code that violates the law of demeter won't be transformable.

I suspect we can merge this, and circle back if it turns out to be extremely painful (i suspect it will) but we can implement the missing features in the legacy-addon on-demand.

[ghost]

I removed this branch per accident.