Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Add return statement for extend. #11603

Merged
merged 1 commit into from
Jun 30, 2015

Conversation

nathanhammond
Copy link
Member

Results in the value being undefined after an extend call.

@rwjblue
Copy link
Member

rwjblue commented Jun 30, 2015

While returning seems fine, I don't see how changing 'init' here changes extend behavior. Can you add a test (both for LinkComponent without a deprecation and LinkView with one)? The test will help me understand the issue better and help us prevent future regressions...

@rwjblue
Copy link
Member

rwjblue commented Jun 30, 2015

Seems like you might have meant to add the return to the extend a few lines below?

@nathanhammond
Copy link
Member Author

Yep. I did intend that to go a few lines south of where I threw it. :/ Still want a test? Or is that a clear change for correctness?

Results in the value being `undefined` after an `extend` call.
stefanpenner added a commit that referenced this pull request Jun 30, 2015
[BUGFIX] Add return statement for extend.
@stefanpenner stefanpenner merged commit 0472f7a into emberjs:stable Jun 30, 2015
@stefanpenner
Copy link
Member

LGTM

cc @truenorth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants