Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC Release] Mark ObjectProxy as public #11599

Merged
merged 1 commit into from
Jul 6, 2015
Merged

[DOC Release] Mark ObjectProxy as public #11599

merged 1 commit into from
Jul 6, 2015

Conversation

joeruello
Copy link
Contributor

Maybe a controversial one, defiantly a "power user" feature. Seems to be used a lot in the real world, but I don't know if moving forward it will continue to be supported.

Also not sure of the relationship to ES6 Proxies, maybe a possible replacement moving forward?

@stefanpenner
Copy link
Member

My vote is to keep this private for now. Would love to here other thoughts

@btecu
Copy link
Contributor

btecu commented Jun 30, 2015

We use this heavily along with ArrayProxy. They are extremely useful for dynamic tables and are helpful for components because they allow them have their own state without mutating the model.

@stefanpenner
Copy link
Member

We use this heavily along with ArrayProxy. Their extremely useful for dynamic tables and are helpful for components because they allow them have their own state without mutating the model.

An alternative, and significantly more flexible approach: https://github.com/stefanpenner/ember-state-services

@btecu
Copy link
Contributor

btecu commented Jun 30, 2015

That may work for some state but it would be a lot more verbose to use compared with ObjectProxy. Also, it doesn't replace ObjectProxy and ArrayProxy functionality.

@stefanpenner
Copy link
Member

@btecu verbose merely indicates more work is needed to polish that use case.

@joeruello
Copy link
Contributor Author

That's a pretty cool addon, but I can imagine using ObjectProxies as states. Seems more of a better way of managing state objects rather than a replacement.

Also currently lacks a way to iterate over states, but I'm sure that's trivial to implement.

@stefanpenner
Copy link
Member

Ya. Infact the default example uses a proxy :p

@dukex
Copy link

dukex commented Jul 1, 2015

Why ObjectProxy is private? I never noticed it, and I used this class today after see the ember-simple-auth(session.js) uses too

@joeruello
Copy link
Contributor Author

@dukex: #11362 enforced marking docs explicitly to end confusion on what is Public/Private API. I'm having a look through and flagging code I think may have been incorrectly marked.

@rwjblue
Copy link
Member

rwjblue commented Jul 3, 2015

I think this should be marked public (since it is essentially defacto public at this point anyways), and we should go through a deprecation phase if/when we decide to remove it in the future.

stefanpenner added a commit that referenced this pull request Jul 6, 2015
[DOC Release] Mark ObjectProxy as public
@stefanpenner stefanpenner merged commit a9e8379 into emberjs:master Jul 6, 2015
@sandstrom
Copy link
Contributor

Great, thanks! We've used it for some advanced things, it's very handy!

@toranb
Copy link
Contributor

toranb commented Sep 16, 2015

public +1

1 similar comment
@greyhwndz
Copy link

public +1

@pixelhandler
Copy link
Contributor

More background… emberjs/rfcs#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants