-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC Release] Mark ObjectProxy as public #11599
Conversation
My vote is to keep this private for now. Would love to here other thoughts |
We use this heavily along with |
An alternative, and significantly more flexible approach: https://github.com/stefanpenner/ember-state-services |
That may work for some state but it would be a lot more verbose to use compared with |
@btecu verbose merely indicates more work is needed to polish that use case. |
That's a pretty cool addon, but I can imagine using ObjectProxies as states. Seems more of a better way of managing state objects rather than a replacement. Also currently lacks a way to iterate over states, but I'm sure that's trivial to implement. |
Ya. Infact the default example uses a proxy :p |
Why ObjectProxy is private? I never noticed it, and I used this class today after see the ember-simple-auth(session.js) uses too |
I think this should be marked public (since it is essentially defacto public at this point anyways), and we should go through a deprecation phase if/when we decide to remove it in the future. |
[DOC Release] Mark ObjectProxy as public
Great, thanks! We've used it for some advanced things, it's very handy! |
public +1 |
1 similar comment
public +1 |
More background… emberjs/rfcs#80 |
Maybe a controversial one, defiantly a "power user" feature. Seems to be used a lot in the real world, but I don't know if moving forward it will continue to be supported.
Also not sure of the relationship to ES6 Proxies, maybe a possible replacement moving forward?