[CLEANUP Beta] remove Object.defineProperty polyfil #11462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -231,8 +228,8 @@ Ember.GUID_KEY = GUID_KEY; | |||
| Ember.create = create; | |||
| Ember.keys = keys; | |||
| Ember.platform = { | |||
| defineProperty: defineProperty, | |||
| hasPropertyAccessors: hasPropertyAccessors | |||
| defineProperty: true, defineProperty, | |||
There was a problem hiding this comment.
^ defineProperty: true,defineProperty,
stefanpenner
force-pushed
the
define-property-cleanup
branch
5 times, most recently
from
6630417
to
a45761f
Compare
(╯°□°）╯︵ ʃıɟʎʃod¬ ʎʇɹǝdoɹdǝuıɟǝp¬
stefanpenner
force-pushed
the
define-property-cleanup
branch
from
a45761f
to
edcf8b6
Compare
stefanpenner
added a commit
that referenced
this pull request
Jun 15, 2015
[CLEANUP Beta] remove Object.defineProperty polyfil
| @@ -144,7 +139,7 @@ export function defineProperty(obj, keyName, desc, data, meta) { | |||
| value = desc; | |||
|
|
|||
| // compatibility with ES5 | |||
| objectDefineProperty(obj, keyName, desc); | |||
| Object.oefineProperty(obj, keyName, desc); | |||
There was a problem hiding this comment.
oefineProperty => defineProperty
There was a problem hiding this comment.
@marcioj - Great catch! Could you submit a PR fixing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(╯°□°）╯︵ ʃıɟʎʃod¬ ʎʇɹǝdoɹdǝuıɟǝp¬