[CLEANUP Beta] Drop Object.create polyfill – just use Object.create [E… #11460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
changed the title
|
Needs rebase. |
| @@ -100,4 +100,4 @@ if (!(Object.create && !Object.create(null).hasOwnProperty)) { | |||
| create = Object.create; | |||
| } | |||
|
|
|||
| export default create; | |||
| export default Object.create; | |||
There was a problem hiding this comment.
Can't you just delete this file?
There was a problem hiding this comment.
Yes, we likely should. We are still exporting Ember.create = Object.create for global export support, but that shouldn't require this file...
stefanpenner
force-pushed
the
remove-object-create-polyfil
branch
4 times, most recently
from
9183a7c
to
4260df4
Compare
…S5-only] (╯°□°）╯︵ ʃıɟʎʃod ǝʇɐǝɹɔ ʇɔǝɾqo
stefanpenner
force-pushed
the
remove-object-create-polyfil
branch
from
4260df4
to
d35a67b
Compare
stefanpenner
added a commit
that referenced
this pull request
Jun 15, 2015
[CLEANUP Beta] Drop Object.create polyfill – just use Object.create [E…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…S5-only]
(╯°□°）╯︵ ʃıɟʎʃod ǝʇɐǝɹɔ ʇɔǝɾqo