[CLEANUP Beta] Remove EmberKeys (internally) continue to expose Ember… #11459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
remove-object-keys
branch
5 times, most recently
from
edb7417
to
3d6c655
Compare
….keys but as 1:1 with Object.keys [ES5-only] (╯°□°）╯︵ sʎǝʞ¬
stefanpenner
force-pushed
the
remove-object-keys
branch
from
3d6c655
to
62f1748
Compare
| import compile from 'ember-template-compiler/system/compile'; | ||
|
|
||
| import 'ember-routing'; |
There was a problem hiding this comment.
I believe that this is needed for side-effects. Specifically, the run loop queues that are created come to mind (though I could be wrong).
There was a problem hiding this comment.
good catch, although surprisingly no tests failed ;(
…S5-only] (╯°□°）╯︵ ʃıɟʎʃod ǝʇɐǝɹɔ ʇɔǝɾqo
stefanpenner
force-pushed
the
remove-object-keys
branch
from
62f1748
to
3f8df7a
Compare
stefanpenner
added a commit
that referenced
this pull request
Jun 18, 2015
[CLEANUP Beta] Remove EmberKeys (internally) continue to expose Ember…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
….keys but as 1:1 with Object.keys [ES5-only]
(╯°□°）╯︵ sʎǝʞ¬