Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP Beta] (╯°□°）╯︵ ʇǝs #11447

Merged
merged 1 commit into from
Jun 15, 2015
Merged

[CLEANUP Beta] (╯°□°）╯︵ ʇǝs #11447

merged 1 commit into from
Jun 15, 2015

Conversation

stefanpenner
Copy link
Member

No description provided.

@rwjblue
Copy link
Member

rwjblue commented Jun 14, 2015

LGTM

@stefanpenner stefanpenner force-pushed the remove-deprecated-ember-set branch 2 times, most recently from b55cd6f to 1ef1a84 Compare June 14, 2015 21:18
@stefanpenner stefanpenner changed the title [CLEANUP Beta] remove the long deprecated Ember.Set [CLEANUP Beta] (╯°□°）╯︵ ʇǝs Jun 14, 2015
@rwjblue
Copy link
Member

rwjblue commented Jun 15, 2015

Needs a rebase.

@stefanpenner
[CLEANUP Beta] (╯°□°）╯︵ ʇǝs
48391b6 
remove the long deprecated Ember.Set
rwjblue added a commit that referenced this pull request Jun 15, 2015
@rwjblue
Merge pull request #11447 from stefanpenner/remove-deprecated-ember-set
0336d40 
[CLEANUP Beta] (╯°□°）╯︵ ʇǝs
@rwjblue rwjblue merged commit 0336d40 into emberjs:master Jun 15, 2015
@rwjblue rwjblue deleted the remove-deprecated-ember-set branch June 15, 2015 05:22
@knownasilya
Copy link
Contributor

Does this mean changing all code (for 2.0) from this.set('key', val) and Ember.set(this, 'key', val) to this.key = val?

@jonnii
Copy link

jonnii commented Jun 15, 2015

@knownasilya no, it means you can't use Ember.Set (http://emberjs.com/api/classes/Ember.Set.html). Different kind of set.

@knownasilya
Copy link
Contributor

Ops, missed that.. ignore me 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stefanpenner @rwjblue @knownasilya @jonnii