Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating context bindings for collection views #10353

Merged
merged 1 commit into from
Feb 4, 2015
Merged

Avoid creating context bindings for collection views #10353

merged 1 commit into from
Feb 4, 2015

Conversation

mmun
Copy link
Member

@mmun mmun commented Feb 4, 2015

@ebryn
Copy link
Member

ebryn commented Feb 4, 2015

yesssssss

@mmun mmun force-pushed the no-context-binding branch from 34d433f to a257607 Compare February 4, 2015 06:15
@mmun mmun changed the title Don't create context binding for non-context changing collection views Avoid creating context bindings for collection views Feb 4, 2015
ebryn added a commit that referenced this pull request Feb 4, 2015
@ebryn
Merge pull request #10353 from mmun/no-context-binding
399e8fb 
Avoid creating context bindings for collection views
@ebryn ebryn merged commit 399e8fb into emberjs:master Feb 4, 2015
@mmun mmun deleted the no-context-binding branch February 4, 2015 06:30
@stefanpenner
Copy link
Member

huh nice, that simplified nicely. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmun @ebryn @stefanpenner