Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add 'autocomplete' to Ember.Select view #10200

Merged
merged 1 commit into from
Feb 28, 2015

Conversation

jednano
Copy link
Contributor

@jednano jednano commented Jan 12, 2015

This would enable Chrome Autofill and similar mechanisms to know what value to select in the select box.

@trek
Copy link
Member

trek commented Jan 13, 2015

Are there no additional tests needed? Can you make sure this gets squashed to a single commit and gets appropriately tagged. See https://github.com/emberjs/ember.js/blob/master/CONTRIBUTING.md

@jednano
Copy link
Contributor Author

jednano commented Jan 13, 2015

@trek there are no additional tests needed. Similar HTML 5 attributes also don't have tests. If a test was needed it would only be to verify that attributeBindings is working properly, but that's really outside the scope of this PR.

The 2 commits have now been squashed into 1 and tagged appropriately.

@jednano jednano changed the title Add 'autocomplete' to Ember.Select view [FEATURE] Add 'autocomplete' to Ember.Select view Jan 13, 2015
wagenet added a commit that referenced this pull request Feb 28, 2015
[FEATURE] Add 'autocomplete' to Ember.Select view
@wagenet wagenet merged commit d708701 into emberjs:master Feb 28, 2015
@jednano jednano deleted the autocomplete branch February 28, 2015 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants