Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.0-beta.2] this undefined in Ember.computed.map callback #11736

Closed
SebastianEdwards opened this issue Jul 13, 2015 · 5 comments
Closed

[2.0.0-beta.2] this undefined in Ember.computed.map callback #11736

SebastianEdwards opened this issue Jul 13, 2015 · 5 comments

Comments

@SebastianEdwards
Copy link

this is undefined in the Ember.computed.map callback. Worked up until the latest beta.
@stefanpenner
Copy link
Member

looking

@stefanpenner
Copy link
Member

yup: https://github.com/emberjs/ember.js/blob/master/packages/ember-runtime/lib/computed/reduce_computed_macros.js#L176

@stefanpenner
Copy link
Member

writing a test now

@stefanpenner
Copy link
Member

submitted fixed

@SebastianEdwards
Copy link
Author

Wowzers, that is an impressive response time 😄 thanks Stefan

rwjblue added a commit that referenced this issue Jul 14, 2015
@rwjblue
Merge pull request #11737 from stefanpenner/ac-this
9df93dc 
[BUGFIX beta] [fixes #11736] ensure array computed macro’s have corre…
stefanpenner added a commit that referenced this issue Jul 14, 2015
@stefanpenner @rwjblue
[BUGFIX beta] [fixes #11736] ensure array computed macro’s have corre…
b348325 
…ct this

(cherry picked from commit 965f490)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanpenner @SebastianEdwards