-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returning an Object from computed property can loose data binding. #10539
Comments
seems like a regression. |
Playing around more with this looks like this commit is when it broke: 8714aba The previous commit works as expected: I'm basing this on travis builds on master since that is the only way I know to get builds I can throw in JSbin. I'm willing to put sometime to figure this out if anyone can point me in the right direction. |
So this is my EmberConf project, to understand and hopefully fix this. Turns out its more pervasive than I originally thought. Returning a regular |
This recreates emberjs#10539 in a unit test
This is a little bit weird, but basically In my app I'm returning the result of a ember data
find
from a computed property, and use the PromiseProxy flagisPending
to show a loading spinner. When the route first loads this works fine.On subsequent returns from the computed property the object is returned correctly (you can see this by the ember id increasing in my jsbins) but the isPending properties are never updated.
If I stash the promise on
window
and inspect it manually int he consoleisPending
is changing, its just not reflected in the rendered output of the app.Hope this makes sense.
Broken on Canary: http://emberjs.jsbin.com/repoqi/1/edit?html,output
Working on 1.9.1: http://emberjs.jsbin.com/zewule/1/edit?html,js,output
The text was updated successfully, but these errors were encountered: