Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

queryParams: pluses aren't converted to spaces #10190

Closed
oriSomething opened this issue Jan 11, 2015 · 4 comments · Fixed by tildeio/route-recognizer#40 or #10268
Closed

queryParams: pluses aren't converted to spaces #10190

oriSomething opened this issue Jan 11, 2015 · 4 comments · Fixed by tildeio/route-recognizer#40 or #10268
Assignees
@machty
Labels
Bug

Comments

@oriSomething
Copy link

as you can see in this link:
http://uploads.orilivni.com/ember/query-params/

technically it's not a bug because there is no standard to what supposed to be encoded / decoded. but decodeURIComponent doesn't convert +s to spaces. so right now if i send a link through facebook i the receiver will get a link where %20 is converted to + and the link is broken.

the link is ember canary. but i had the same problem with version 1.9.1

thanks
@trek trek assigned trek and machty and unassigned trek Jan 12, 2015
@trek trek added the Bug label Jan 12, 2015
@jayphelps jayphelps mentioned this issue Jan 16, 2015
Merged
@wagenet
Copy link
Member

wagenet commented Jan 21, 2015

Looks like this is fixed by tildeio/route-recognizer#40.

@wagenet wagenet closed this as completed Jan 21, 2015
@jayphelps
Copy link
Contributor

@wagenet Can we keep this ticket open until this fix lands in ember.js/master? Since it requires that PR be merged, a version cut, a PR made for ember.js updating it and then it merged, I think it's important to have a record open.

@wagenet wagenet reopened this Jan 21, 2015
@rwjblue
Copy link
Member

rwjblue commented Jan 22, 2015

Reopening until the dep is updated.

@rwjblue rwjblue reopened this Jan 22, 2015
jayphelps added a commit to jayphelps/ember.js that referenced this issue Jan 22, 2015
@jayphelps
Bumped sha to get tildeio/route-recognizer#40, which fixes emberjs#10190
6f7b1c4
@jayphelps jayphelps mentioned this issue Jan 22, 2015
Merged
rwjblue added a commit that referenced this issue Jan 22, 2015
@rwjblue
Merge pull request #10268 from jayphelps/update-rr
872c1f9 
Bumped sha to get tildeio/route-recognizer#40, which fixes #10190
rwjblue pushed a commit that referenced this issue Jan 25, 2015
@jayphelps @rwjblue
Bumped sha to get tildeio/route-recognizer#40, which fixes #10190
afd8a91 
Conflicts:
	bower.json
@meghasharma92
Copy link

I am facing the problem of conversion of space to + in queryParams..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@machty machty

Labels
Bug
Projects
None yet
Milestone
No milestone
7 participants
@trek @wagenet @rwjblue @machty @jayphelps @oriSomething @meghasharma92