Merge pull request #13289 from rwjblue/lastobject-readonly

Make Enumerable#lastObject readOnly.
emberjs · Apr 10, 2016 · fc29bc5 · fc29bc5
2 parents b29d10c + c31c50e
commit fc29bc5
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/packages/ember-runtime/lib/mixins/array.js b/packages/ember-runtime/lib/mixins/array.js
@@ -209,7 +209,7 @@ export default Mixin.create(Enumerable, {
 
   lastObject: computed(function() {
     return objectAt(this, get(this, 'length') - 1);
-  }),
+  }).readOnly(),
 
   // optimized version from Enumerable
   contains(obj) {

diff --git a/packages/ember-runtime/lib/mixins/enumerable.js b/packages/ember-runtime/lib/mixins/enumerable.js
@@ -188,6 +188,7 @@ var Enumerable = Mixin.create({
 
     @property lastObject
     @return {Object} the last object or undefined
+    @readOnly
     @public
   */
   lastObject: computed('[]', function() {
@@ -210,7 +211,7 @@ var Enumerable = Mixin.create({
     pushCtx(context);
 
     return last;
-  }),
+  }).readOnly(),
 
   /**
     Returns `true` if the passed object can be found in the receiver. The

diff --git a/packages/ember-runtime/tests/suites/enumerable/lastObject.js b/packages/ember-runtime/tests/suites/enumerable/lastObject.js
@@ -1,5 +1,6 @@
 import {SuiteModuleBuilder} from 'ember-runtime/tests/suites/suite';
 import {get} from 'ember-metal/property_get';
+import {set} from 'ember-metal/property_set';
 
 var suite = SuiteModuleBuilder.create();
 
@@ -18,4 +19,15 @@ suite.test('returns undefined if enumerable is empty', function() {
   equal(get(obj, 'lastObject'), undefined);
 });
 
+suite.test('can not be set', function() {
+  var obj = this.newObject();
+  var ary = this.toArray(obj);
+
+  equal(get(obj, 'lastObject'), ary[ary.length - 1]);
+
+  throws(function() {
+    set(obj, 'lastObject', 'foo!');
+  }, /Cannot set read-only property "lastObject" on object/);
+});
+
 export default suite;