-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[BUGFIX release] Fix mergedProperties at create time modifying proto
When `mergedProperties` are passed into an object at `.create()` time, the objects prototype is inadvertently modified, which is then reflected on all instances of the object. Simply passing in a new object during `assign()` resolves this problem (per krisselden). Also added a test for this use case, where `objA` results in 3 when the proto is modified. Fixes #11714
- Loading branch information
Showing
2 changed files
with
24 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters