Skip to content

Commit

Permalink
Merge pull request #14883 from intercom/gj/simplify-action-modifier-m…
Browse files Browse the repository at this point in the history
…anager

[BUGFIX beta] simplify ActionModifierManager.update
  • Loading branch information
rwjblue authored Jan 28, 2017
2 parents e1f8ad2 + c9d1686 commit af27853
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions packages/ember-glimmer/lib/modifiers/action.js
Original file line number Diff line number Diff line change
Expand Up @@ -208,17 +208,13 @@ export default class ActionModifierManager {

update(actionState) {
let { positional } = actionState;

let actionNameRef = positional.at(1);

if (!actionNameRef[INVOKE]) {
actionState.actionName = actionNameRef.value();
}
actionState.eventName = actionState.getEventName();

// Not sure if this is needed? If we mutate the actionState is that good enough?
ActionHelper.unregisterAction(actionState);
ActionHelper.registerAction(actionState);
actionState.eventName = actionState.getEventName();
}

getDestructor(modifier) {
Expand Down

0 comments on commit af27853

Please sign in to comment.