Merge pull request #15162 from emberjs/cp-14947

CherryPick tests from 14947
emberjs · Apr 24, 2017 · adcc0e0 · adcc0e0
2 parents e36d849 + a97f8c5
commit adcc0e0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/packages/ember-glimmer/lib/components/checkbox.js b/packages/ember-glimmer/lib/components/checkbox.js
@@ -51,7 +51,6 @@ export default EmberComponent.extend({
   ],
 
   type: 'checkbox',
-  checked: false,
   disabled: false,
   indeterminate: false,
 
@@ -61,6 +60,6 @@ export default EmberComponent.extend({
   },
 
   change() {
-    set(this, 'checked', this.$().prop('checked'));
+   set(this, 'checked', this.$().prop('checked'));
   }
 });
diff --git a/packages/ember-glimmer/tests/integration/helpers/input-test.js b/packages/ember-glimmer/tests/integration/helpers/input-test.js
@@ -535,6 +535,17 @@ moduleFor(`Helpers test: {{input type='checkbox'}}`, class extends InputRenderin
     this.assertCheckboxIsChecked();
   }
 
+  ['@test native click changes check property'](assert) {
+    this.render(`{{input type="checkbox"}}`);
+
+    this.assertSingleCheckbox();
+    this.assertCheckboxIsNotChecked();
+    this.$input()[0].click();
+    this.assertCheckboxIsChecked();
+    this.$input()[0].click();
+    this.assertCheckboxIsNotChecked();
+  }
+
   ['@test with static values'](assert) {
     this.render(`{{input type="checkbox" disabled=false tabindex=10 name="original-name" checked=false}}`);
 
@@ -552,7 +563,6 @@ moduleFor(`Helpers test: {{input type='checkbox'}}`, class extends InputRenderin
     this.assertAttr('tabindex', '10');
     this.assertAttr('name', 'original-name');
   }
-
 });
 
 moduleFor(`Helpers test: {{input type='text'}}`, class extends InputRenderingTest {