Skip to content

Commit

Permalink
Merge pull request #14338 from eventualbuddha/no-initializer-name
Browse files Browse the repository at this point in the history 
blueprints: remove explicit names from initializers.
  • Loading branch information
@stefanpenner
stefanpenner committed May 22, 2017
2 parents 0a0959b + 15c10d5 commit 68e73c3
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 26 deletions.
1 change: 0 additions & 1 deletion blueprints/initializer/files/__root__/initializers/__name__.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ export function initialize(/* application */) {
}

export default {
name: '<%= dasherizedModuleName %>',
initialize
};
1 change: 0 additions & 1 deletion blueprints/instance-initializer/files/__root__/instance-initializers/__name__.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ export function initialize(/* appInstance */) {
}

export default {
name: '<%= dasherizedModuleName %>',
initialize
};
12 changes: 0 additions & 12 deletions node-tests/blueprints/initializer-test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo',\n" +
" initialize\n" +
"};");

Expand All @@ -44,7 +43,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo/bar',\n" +
" initialize\n" +
"};");

Expand All @@ -64,7 +62,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo',\n" +
" initialize\n" +
"};");

Expand All @@ -87,7 +84,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo/bar',\n" +
" initialize\n" +
"};");

Expand All @@ -110,7 +106,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo',\n" +
" initialize\n" +
"};");

Expand All @@ -133,7 +128,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo/bar',\n" +
" initialize\n" +
"};");

Expand All @@ -156,7 +150,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo',\n" +
" initialize\n" +
"};");

Expand All @@ -179,7 +172,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo/bar',\n" +
" initialize\n" +
"};");

Expand All @@ -204,7 +196,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo',\n" +
" initialize\n" +
"};");
}));
Expand All @@ -222,7 +213,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo',\n" +
" initialize\n" +
"};");
}));
Expand All @@ -239,7 +229,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo/bar',\n" +
" initialize\n" +
"};");
}));
Expand All @@ -258,7 +247,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo/bar',\n" +
" initialize\n" +
"};");
}));
Expand Down
12 changes: 0 additions & 12 deletions node-tests/blueprints/instance-initializer-test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo',\n" +
" initialize\n" +
"};");

Expand All @@ -44,7 +43,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo/bar',\n" +
" initialize\n" +
"};");

Expand All @@ -64,7 +62,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo',\n" +
" initialize\n" +
"};");

Expand All @@ -86,7 +83,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo/bar',\n" +
" initialize\n" +
"};");

Expand All @@ -108,7 +104,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo',\n" +
" initialize\n" +
"};");

Expand All @@ -131,7 +126,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo/bar',\n" +
" initialize\n" +
"};");

Expand All @@ -154,7 +148,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo',\n" +
" initialize\n" +
"};");

Expand All @@ -177,7 +170,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo/bar',\n" +
" initialize\n" +
"};");

Expand All @@ -202,7 +194,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo',\n" +
" initialize\n" +
"};");
}));
Expand All @@ -220,7 +211,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo',\n" +
" initialize\n" +
"};");
}));
Expand All @@ -237,7 +227,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo/bar',\n" +
" initialize\n" +
"};");
}));
Expand All @@ -256,7 +245,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
" name: 'foo/bar',\n" +
" initialize\n" +
"};");
}));
Expand Down

0 comments on commit 68e73c3

Please sign in to comment.