[DOC lts] Addressed PR comments by rwjblue

(cherry picked from commit dc9cc71)
emberjs · Feb 12, 2019 · 472673d · 472673d
1 parent 8a42b3b
commit 472673d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/packages/@ember/-internals/glimmer/lib/helpers/component.ts b/packages/@ember/-internals/glimmer/lib/helpers/component.ts
@@ -112,7 +112,7 @@
 
   ```
   <PersonForm as |form|>
-    <form.nameInput @placeholder={{"Username"}} />
+    <form.nameInput @placeholder="Username" />
   </PersonForm>
   ```
 

diff --git a/packages/@ember/-internals/glimmer/lib/helpers/concat.ts b/packages/@ember/-internals/glimmer/lib/helpers/concat.ts
@@ -22,13 +22,15 @@ const normalizeTextValue = (value: any): string => {
   Example:
 
   ```handlebars
-  <SomeComponent @name={{concat firstName " " lastName}} />
+  {{some-component name=(concat firstName " " lastName)}}
 
   {{! would pass name="<first name value> <last name value>" to the component}}
   ```
-  or
+
+  or for angle bracket invocation, you actually don't need concat at all.
+
   ```handlebars
-  {{some-component name=(concat firstName " " lastName)}}
+  <SomeComponent @name="{{firstName lastName}}" />
   ```
 
   @public

diff --git a/packages/@ember/-internals/glimmer/lib/helpers/if-unless.ts b/packages/@ember/-internals/glimmer/lib/helpers/if-unless.ts
@@ -118,7 +118,7 @@ class ConditionalHelperReference extends CachedReference {
   You can use the `if` helper inside another helper as a nested helper:
 
   ```handlebars
-  <SomeComponent height={{if isBig "100" "10"}} />
+  <SomeComponent @height={{if isBig "100" "10"}} />
   ```
 
   or
@@ -157,7 +157,7 @@ export function inlineIf(_vm: VM, { positional }: Arguments) {
   You can use the `unless` helper inside another helper as a subexpression.
 
   ```handlebars
-  <SomeComponent height={{unless isBig "10" "100"}} />
+  <SomeComponent @height={{unless isBig "10" "100"}} />
   ```
 
   or