Require ember-auto-import@v2 #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
force-pushed
the
require-ember-auto-import@v2
branch
from
5e2b737 to
ddd1aaa
Compare
29 tasks
NullVoxPopuli
force-pushed
the
require-ember-auto-import@v2
branch
from
ddd1aaa to
da698dc
Compare
NullVoxPopuli
commented
Sep 25, 2023
NullVoxPopuli
commented
Sep 25, 2023
| @@ -86,7 +86,8 @@ | |||
| "qunit": "^2.16.0", | |||
| "release-it": "^14.14.3", | |||
| "release-it-lerna-changelog": "^3.1.0", | |||
| "typescript": "~4.4.2" | |||
| "typescript": "~4.4.2", | |||
| "webpack": "^5.0.0" | |||
There was a problem hiding this comment.
required by ember-auto-import @v2
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context, Plan, etc: https://gist.github.com/NullVoxPopuli/eafc7dad6547de5e730098498b829e1f
This PR is mostly a no-op be eai2 is required to consume v2 addons.
This will be a breaking change.
I breaking change is a bit of a shame, but this is only a semver communication -- the APIs for modern apps should still be the same, and we can recommend overrides configs for folks to ensure that they only have one copy of
@ember/test-waitersin their projects.Moving to a monorepo will allow a good variety of test apps to showcase this.