Fix canary #297
Merged
Fix canary #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TL;DR ember-concurrency 1.x is not supported in 2.x of
stefanpenner
force-pushed
the
fix-canary
branch
from
9658d21
to
5164e46
Compare
|
Speaking with @scalvert, we should likely match ember-try support with ember-test-helpers. Which will require a major version bump. |
stefanpenner
force-pushed
the
fix-canary
branch
2 times, most recently
from
66114cb
to
7af2e00
Compare
stefanpenner
force-pushed
the
fix-canary
branch
from
7af2e00
to
f1ae1d9
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the canary try-scenario... let's see how the other scenarios appreciate it...