Failing test for helpers using runHooks being unsettled after resolving
#956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a number of (currently failing) tests that are
attempting to confirm that after running various public methods that
we are in a settled state.
The tests all fail at the moment, because the `Promise.all` that is done
wihtin `runHooks` does **not** go through our custom
`RSVP.configure('async', fn)`. This is because the `async` hook in RSVP
only receives a second argument (the `promise` argument) in some
circumstances but not in the case where the parent promise is not in the
pending state ([this branch in
RSVP](https://github.com/tildeio/rsvp.js/blob/429ade2379dfbfb6e2c6f453b4aeb642515dbb74/lib/rsvp/then.js#L28-L33)).
`RSVP.Promise.all([undefined, undefined])` is considered settled
immediately, so `RSVP.Promise.all().then(fn)` returns a promise that
will **not** get our custom promise resolution scheduling.
Since our custom scheduling is not being used here, the normal `RSVP`
integration is used which means that the promise will resolve in the
`actions` queue of the run loop. Ultimately, this is why `isSettled()`
returns false when `await runHooks(...)` completes: a run loop was
started in order to resolve the `runHooks` promise, but it has not
completed yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a number of (currently failing) tests that are attempting to confirm that after running various public methods that we are in a settled state.
The tests all fail at the moment, because the
Promise.allthat is done wihtinrunHooksdoes not go through our customRSVP.configure('async', fn). This is because theasynchook in RSVPonly receives a second argument (the
promiseargument) in some circumstances but not in the case where the parent promise is not in the pending state (this branch in RSVP).RSVP.Promise.all([undefined, undefined])is consideredsettled immediately, so
RSVP.Promise.all().then(fn)returns a promise that will not get our custom promise resolution scheduling.Since our custom scheduling is not being used here, the normal
RSVPintegration is used which means that the promise will resolve in theactionsqueue of the run loop. Ultimately, this is whyisSettled()returns false whenawait runHooks(...)completes: a run loop was started in order to resolve therunHookspromise, but it has not completed yet.Reproduces the issue reported in #947.