Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ember-test-waiters and integrate into settledness checks #632

Merged
merged 7 commits into from
May 2, 2019

Conversation

scalvert
Copy link
Contributor

@scalvert scalvert commented Apr 23, 2019

This PR integrates the new ember-test-waiters addon into the settled system. It utilizes the new system side-by-side with the legacy test waiters system. Specifically, the new test waiter system gives us

  1. The ability to create named waiters
  2. The ability to add debug information for when a waiter begins async tracking
  3. Primitives that adopters can use to build their own more complicated waiters (though we expect 99% of users will just use the defaults)

This PR:

  • Adds the ember-test-waiters dependency
  • Updates getSettledState to include checking for the new test waiters pending state
  • Updates the TestDebugInfo class to include outputting pending waiter information when a pending waiter is detected
  • Updates all tests to include the new test waiters, and adds tests to include explicit checks for the new test waiters behavior.

@rwjblue
Copy link
Member

rwjblue commented Apr 25, 2019

I think this will need a rebase now that #608 is merged

@scalvert scalvert force-pushed the add-ember-test-waiters branch from 87f8637 to 281096b Compare April 25, 2019 20:10
@scalvert
Copy link
Contributor Author

Rebased. Just waiting on CI.

@scalvert
Copy link
Contributor Author

scalvert commented May 1, 2019

This PR is ready to merge, whenever you have time @rwjblue.

@rwjblue rwjblue merged commit 2519b3f into emberjs:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants