Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds test for presence of store using integration: true in moduleForModel #51

Closed

Conversation

nikz
Copy link
Contributor

@nikz nikz commented May 17, 2015

Hi team!

I'm having a bit of trouble with the latest version of ember-test-helpers. It looks like there was a regression with integration: true somewhere that means container.lookup("store:main") is returning undefined. 😿

I've added a failing test for this, and I'm working on a fix at the moment (although any pointers as to the right direction are greatly appreciated!)

Thanks,

Nik

(ping @rwjblue 😝)

@pgasiorowski
Copy link

A fix seems to be already on it's way #49.
I'm also waiting to be able to pull it but a temp. workaround is calling DS._setupContainer(this.registry);

@nikz
Copy link
Contributor Author

nikz commented May 17, 2015

@WooDzu awesome! thanks for that.

@rwjblue
Copy link
Member

rwjblue commented May 18, 2015

Thank you for the test!! I'll pull it into my branch in #49 and confirm all is working properly there...

@rwjblue
Copy link
Member

rwjblue commented May 18, 2015

I pulled the test into #49 (and removed the equal(123, store) assertion), I'm going to close this PR in favor of that one.

Thank you again for taking the time to submit a failing test!

@rwjblue rwjblue closed this May 18, 2015
@nikz
Copy link
Contributor Author

nikz commented May 18, 2015

@rwjblue no worries, sorry for leaving in the random extra assertion :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants