Use setTimeout for "forced" async.
#239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `Ember.run.next` has a negative impact on developer ergonomics because we loose access to the automatic stack stitching that is done by Chrome (which ends up being very nice when working with `async` / `await`.
|
CI is unhappy... 😞
not sure what this means. do you have a screenshot?
what do you mean by "improved ergonomics"? |
|
Ya, I’ll grab a screenshot to show what I mean shortly. |
I believe that I may have been suffering from the poor ergonomics that emberjs/ember.js#15871 is addressing. Closing for now, will revisit if this isn't solved by an Ember bump... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Ember.run.nexthas a negative impact on developer ergonomics because we loose access to the automatic stack stitching that is done by Chrome (which ends up being very nice when working withasync/await.Other than improved ergonomics if a failure occurs during setup or teardown, there should be no perceived changes from this PR...